Skip to content

Conversation

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2025

@bitoku: This pull request references OCPNODE-3121 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR graduates ImageVolume FG to GA.

The test results:
https://sippy.dptools.openshift.org/sippy-ng/tests/4.20?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522name%2522%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522FeatureGate%253AImageVolume%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

Hello @bitoku! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 15, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed August 15, 2025 11:56
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2025
Signed-off-by: Ayato Tokubi <[email protected]>
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 15, 2025
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@bitoku: This PR was included in a payload test run from openshift/origin#30122
trigger 10 job(s) of type blocking for the nightly release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c74b1d0-79d2-11f0-9fa6-bcacab0bfed7-0

@bitoku
Copy link
Contributor Author

bitoku commented Aug 18, 2025

/retest

1 similar comment
@bitoku
Copy link
Contributor Author

bitoku commented Aug 19, 2025

/retest

@bitoku
Copy link
Contributor Author

bitoku commented Aug 19, 2025

@haircommander @JoelSpeed PTAL

@bitoku bitoku changed the title WIP: OCPNODE-3121: Graduate ImageVolume to GA OCPNODE-3121: Graduate ImageVolume to GA Aug 19, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2025
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@bitoku
Copy link
Contributor Author

bitoku commented Aug 19, 2025

/retest-required

@haircommander
Copy link
Member

🎉

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 21f935b and 2 for PR HEAD 2bacf2c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4bbb180 and 1 for PR HEAD 2bacf2c in total

@bitoku
Copy link
Contributor Author

bitoku commented Aug 19, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4bbb180 and 2 for PR HEAD 2bacf2c in total

@bitoku
Copy link
Contributor Author

bitoku commented Aug 20, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6282350 and 1 for PR HEAD 2bacf2c in total

@haircommander
Copy link
Member

/skip

@bitoku
Copy link
Contributor Author

bitoku commented Aug 20, 2025

@JoelSpeed

Can we override ci/prow/e2e-aws-ovn-hypershift-conformance ?

It passed before and the failed test is a long standing flaky test.
https://issues.redhat.com/browse/OCPBUGS-57477

@everettraven
Copy link
Contributor

Overriding ci/prow/e2e-aws-ovn-hypershift-conformance because of a known regression unrelated to this change (https://issues.redhat.com/browse/OCPBUGS-57477).

/override e2e-aws-ovn-hypershift-conformance

@everettraven
Copy link
Contributor

/test e2e-aws-serial-techpreview-2of2

@everettraven
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@everettraven: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-ovn-hypershift-conformance

Only the following failed contexts/checkruns were expected:

  • ci/prow/build
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-hypershift
  • ci/prow/e2e-aws-ovn-hypershift-conformance
  • ci/prow/e2e-aws-ovn-techpreview
  • ci/prow/e2e-aws-serial-1of2
  • ci/prow/e2e-aws-serial-2of2
  • ci/prow/e2e-aws-serial-techpreview-1of2
  • ci/prow/e2e-aws-serial-techpreview-2of2
  • ci/prow/e2e-azure
  • ci/prow/e2e-gcp
  • ci/prow/e2e-upgrade
  • ci/prow/e2e-upgrade-out-of-change
  • ci/prow/images
  • ci/prow/integration
  • ci/prow/lint
  • ci/prow/minor-e2e-upgrade-minor
  • ci/prow/minor-images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-client-go
  • ci/prow/verify-crd-schema
  • ci/prow/verify-deps
  • ci/prow/verify-feature-promotion
  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift-conformance
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial-1of2
  • pull-ci-openshift-api-master-e2e-aws-serial-2of2
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview-1of2
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview-2of2
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-e2e-upgrade-out-of-change
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-lint
  • pull-ci-openshift-api-master-minor-e2e-upgrade-minor
  • pull-ci-openshift-api-master-minor-images
  • pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-api-master-okd-scos-images
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps
  • pull-ci-openshift-api-master-verify-feature-promotion
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

Overriding ci/prow/e2e-aws-ovn-hypershift-conformance because of a known regression unrelated to this change (https://issues.redhat.com/browse/OCPBUGS-57477).

/override e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrunalp
Copy link
Member

mrunalp commented Aug 20, 2025

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-ovn-hypershift-conformance

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@mrunalp: Overrode contexts on behalf of mrunalp: ci/prow/e2e-aws-ovn-hypershift-conformance

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06d1bd7 and 0 for PR HEAD 2bacf2c in total

@openshift-ci-robot
Copy link

/hold

Revision 2bacf2c was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@bitoku
Copy link
Contributor Author

bitoku commented Aug 20, 2025

/retest-required

@bitoku
Copy link
Contributor Author

bitoku commented Aug 20, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@bitoku: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2d04128 into openshift:master Aug 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants